Skip to content

UI - Zone Wizard - Fixes the IP range form fields are too narrow#5287

Merged
yadvr merged 2 commits intoapache:4.15from
utchoang:feature/fix-iprange-form
Aug 9, 2021
Merged

UI - Zone Wizard - Fixes the IP range form fields are too narrow#5287
yadvr merged 2 commits intoapache:4.15from
utchoang:feature/fix-iprange-form

Conversation

@utchoang
Copy link

@utchoang utchoang commented Aug 6, 2021

Description

Fixes #5286

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@utchoang
Copy link
Author

utchoang commented Aug 6, 2021

After changes
Screenshot_1

@utchoang
Copy link
Author

utchoang commented Aug 6, 2021

@blueorangutan ui

@blueorangutan
Copy link

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5287 (SL-JID-483)

@davidjumani
Copy link
Contributor

@utchoang The fields are larger but still not large enough. On Firefox.
Try and get 000.000.000.000 to fit since any range is smaller than that width wise

Screenshot from 2021-08-06 14-05-40

@utchoang
Copy link
Author

utchoang commented Aug 6, 2021

@davidjumani My Firefox still renders fine, but I'll make the field a little wider for your case
image

@utchoang
Copy link
Author

utchoang commented Aug 6, 2021

@blueorangutan ui

@blueorangutan
Copy link

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5287 (SL-JID-486)

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Screenshot from 2021-08-07 01-26-34

@yadvr yadvr merged commit d9503f4 into apache:4.15 Aug 9, 2021
@yadvr yadvr added this to the 4.15.2.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants